[Gecko Bug 1692116] Part 4 - Add WPT reftests, and adjust test expectations. #27782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part 2 fixed table-as-item-inflexible-in-column-{1,2}.html.
table-as-item-inflexible-in-row-{1,2}.html are already pass on Nightly,
and are added for robustness and symmetry.
Part 3 fixed table-as-item-specified-height.html
Part 2 and Part 3 are both needed to not break
layout/reftests/flexbox/flexbox-table-flex-items-3.html.
Differential Revision: https://phabricator.services.mozilla.com/D106158
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1692116
gecko-commit: 415a2c4c73b35d5766e48249e7e38b508224ea5d
gecko-reviewers: dholbert
wpt-pr-bot
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 fixed table-as-item-inflexible-in-column-{1,2}.html.
table-as-item-inflexible-in-row-{1,2}.html are already pass on Nightly,
and are added for robustness and symmetry.
Part 3 fixed table-as-item-specified-height.html
Part 2 and Part 3 are both needed to not break
layout/reftests/flexbox/flexbox-table-flex-items-3.html.
Differential Revision: https://phabricator.services.mozilla.com/D106158
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1692116
gecko-commit: 415a2c4c73b35d5766e48249e7e38b508224ea5d
gecko-reviewers: dholbert