Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 799725] Part 2 - Use StyleSizeOverrides to stretch flex item's inline-size. #27783

Merged
merged 1 commit into from Feb 26, 2021

Conversation

moz-wptsync-bot
Copy link
Collaborator

Also, suppress a flex item's aspect-ratio by using
StyleSizeOverrides::mAspectRatio added in Part 1. Otherwise,
testing/web-platform/tests/css/css-flexbox/flex-minimum-height-flex-items-023.html
is going to break.

table-as-item-stretch-cross-size-3 is adapted from the testcase in bug
799725 comment 1. Note: stretching in the cross axis that is a block
axis has been fixed by bug 1674302.

Differential Revision: https://phabricator.services.mozilla.com/D106195

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=799725
gecko-commit: 0036bd0a605655eb7ac5141aeb646b1362621997
gecko-reviewers: dholbert

Also, suppress a flex item's aspect-ratio by using
StyleSizeOverrides::mAspectRatio added in Part 1. Otherwise,
testing/web-platform/tests/css/css-flexbox/flex-minimum-height-flex-items-023.html
is going to break.

table-as-item-stretch-cross-size-3 is adapted from the testcase in bug
799725 comment 1. Note: stretching in the cross axis that is a block
axis has been fixed by bug 1674302.

Differential Revision: https://phabricator.services.mozilla.com/D106195

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=799725
gecko-commit: 0036bd0a605655eb7ac5141aeb646b1362621997
gecko-reviewers: dholbert
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Firefox project.

@moz-wptsync-bot moz-wptsync-bot merged commit aacc9d2 into master Feb 26, 2021
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/799725 branch February 26, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants