Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Missing or needed spaces #8640

Merged
merged 7 commits into from Feb 5, 2021
Merged

Fix: Missing or needed spaces #8640

merged 7 commits into from Feb 5, 2021

Conversation

SamuXarick
Copy link
Contributor

Motivation / Problem

There is some missing spaces or needed spaces around in the code that I happened to find.

Description

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

glx22
glx22 previously approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glx22
Copy link
Contributor

glx22 commented Feb 2, 2021

Do not forget to reword commit message on merge.
I'm not merging yet, just in case @SamuXarick finds more to add ;)

LordAro
LordAro previously approved these changes Feb 2, 2021
View reviewed changes
LordAro
LordAro approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes for a couple of days, quick, merge it!

@glx22 glx22 merged commit a4035af into OpenTTD:master Feb 5, 2021
@SamuXarick SamuXarick deleted the missing-spaces branch February 6, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

@glx22 glx22 glx22 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SamuXarick @glx22 @LordAro