Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cc39fa9: New orders are non-stop by default #8689

Merged
merged 1 commit into from Feb 18, 2021

Conversation

2TallTyler
Copy link
Member

Motivation / Problem

In cc39fa9, I changed a legacy setting for non-stop orders instead of the setting currently used. It didn't work and could potentially break old savegames.

Description

This PR reverts the change to the legacy setting, and changes the correct setting instead.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain merged commit fa88cb6 into OpenTTD:master Feb 18, 2021
@2TallTyler 2TallTyler deleted the nonstop_order_fix branch February 18, 2021 17:49
@2TallTyler 2TallTyler restored the nonstop_order_fix branch February 24, 2021 21:44
@2TallTyler 2TallTyler deleted the nonstop_order_fix branch February 27, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants