Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number manœuvres idiomatically, tweak time-related words #2897

Merged
merged 3 commits into from
Feb 20, 2021

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Feb 18, 2021

As alluded to in #2890,

Some day we may want to change 轨道机动 #𝑛 to 第𝑛次轨道机动 (I suspect this is currently messing with the word order when it comes to referring to the final time of a manœuvre), but this will have to come in a subsequent release.

Use ordinals (in the linguistic sense, i.e., « 𝑛th manœuvre », rather than cardinals as in « manœuvre number 𝑛 ») as they don’t require any particular logic in Chinese (contrary to English -st -nd -rd -th).

Reworded starting and ending point to starting and ending time when referring to times.

Reworded 加速 to 时间加速 for « [time] warp »; 加速 simply means « accelerate », which is a lot more overloaded here than the original « warp ». 加速至轨道机动起点 « accelerate until manœuvre starting point » could have led to confusion, for which
时间加速至轨道机动开始时刻 « accelerate time until manœuvre starting time » should leave no room.

As a result of the numbering and point-to-time changes 轨道机动终点 #<<1>> becomes 第<<1>>次轨道机动结束时.

@Zaikarion pointed out that the term 时基 « time base » does not mean what we want it to.
Admittedly it is dubious in English to start with, as we are lifting its meaning of « time zero » from some obscure Apollo-Saturn documents. 时基 only has the more common electronics-related sense of « time base ». @Zaikarion suggested 计时起点 « timing start point ».

Screenshot of the flight plan UI, with changes highlighted:
image

#Principia_FlightPlan_StatusMessage_OutRange1 = 轨道机动 #<<1>> 与 <<2>> 重叠 或者 <<3>> // TODO(phl): Added <<3>> at a random place.
#Principia_FlightPlan_StatusMessage_Infinite = <<1>>次轨道机动 会产生无限或不确定的速度 // <<1>> Error Manœuvre
#Principia_FlightPlan_StatusMessage_Adjust = 调整第<<1>>次轨道机动的持续时间 // <<1>> Error Manœuvre
#Principia_FlightPlan_StatusMessage_OutRange1 = <<1>>次轨道机动 与 <<2>> 重叠 或者 <<3>> // TODO(phl): Added <<3>> at a random place.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the TODO now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is still at a random place.

@pleroy pleroy added the LGTM label Feb 19, 2021
@eggrobin eggrobin merged commit 6f3c9a1 into mockingbirdnest:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants