URLPattern: Add wildcard '*' support. #27679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 18, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2673887
branch
3 times, most recently
from
90978eb
to
b9e8f69
Compare
This CL adds support for a wildcard `*` character in patterns. It is treated as being equivalent to the `(.*)` unnamed regexp group. This means it can have its own following modifiers like `*?` which can affect how prefix characters are treated. For example, `/foo/*?` will match `/foo` but `/foo/*` will not. This CL deviates from the current upstream path-to-regexp v6.2.0, but we plan to upstream this change. Initial discussions suggest that its possible this will be accepted. Bug: 1141510 Change-Id: I386b03e8bb05aab9586464986faf002e824e189e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2673887 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#856942}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2673887
branch
from
b9e8f69
to
ded540a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds support for a wildcard
*character in patterns. It istreated as being equivalent to the
(.*)unnamed regexp group. Thismeans it can have its own following modifiers like
*?which can affecthow prefix characters are treated. For example,
/foo/*?will match/foobut/foo/*will not.This CL deviates from the current upstream path-to-regexp v6.2.0, but
we plan to upstream this change. Initial discussions suggest that its
possible this will be accepted.
Bug: 1141510
Change-Id: I386b03e8bb05aab9586464986faf002e824e189e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2673887
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856942}