Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Darken graph grid lines for legibility #8690

Merged
merged 1 commit into from Feb 18, 2021

Conversation

2TallTyler
Copy link
Member

Motivation / Problem

See #8630 for explanation of problem.

Closes #8630.

Description

This darkens the grid lines to one shade lighter than the background, as suggested. It would be easy to go lighter, if desired.

It also changes the x-axis ($0) from black to a lighter grey than the other grid lines, for better readability.

Finally, it changes all greyscale color assignments to use the consistent GREY_SCALE() method.

Profit graph:

profit_graph

Payment rates for vanilla cargos:

vanilla_cargos

Limitations

This does not address the other issues raised by @LC-Zorg. I might tackle the period markings next, but one PR at a time.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain merged commit d5e18fe into OpenTTD:master Feb 18, 2021
@2TallTyler 2TallTyler deleted the graph_improvement branch February 18, 2021 13:06
@2TallTyler 2TallTyler restored the graph_improvement branch February 24, 2021 21:44
@2TallTyler 2TallTyler deleted the graph_improvement branch February 27, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants