Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

giara: init at 0.3 #110939

Merged
merged 1 commit into from Mar 21, 2021
Merged

giara: init at 0.3 #110939

merged 1 commit into from Mar 21, 2021

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Jan 27, 2021

Motivation for this change

Continues the work initiated by @Atemu here: #99188

Things done

Updated the source reference to version 0.3

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ryneeverett
ryneeverett reviewed Jan 28, 2021
View reviewed changes
pkgs/applications/networking/giara/default.nix Outdated
strictDeps = false;

meta = with lib; {
description = "A Reddit app, built with Python, GTK and Handy. Created with mobile Linux in mind.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta.description should not have a period at the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks for the heads up

@tomberek
Copy link
Contributor

tomberek commented Mar 3, 2021

Result of nixpkgs-review pr 110939 run on x86_64-linux 1

1 package built:
  • giara

@SuperSandro2000 SuperSandro2000 merged commit 82c5dac into NixOS:master Mar 21, 2021
@fgaz fgaz mentioned this pull request Mar 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryneeverett ryneeverett ryneeverett left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dasj19 @tomberek @ryneeverett @SuperSandro2000