Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: 1.25.0 -> 1.26.0 #110949

Merged
merged 1 commit into from Jan 27, 2021
Merged

Conversation

robintown
Copy link
Contributor

Motivation for this change

Update Synapse to version 1.26.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Jan 27, 2021

We've decided in the nix-matrix channel that a backport makes sense even though the DB schema is not backwards-compatible: Matrix has security fixes quite regularly and applying those by hand is pretty hard, so we'll backport this as long as there's no LTS synapse.

Unless somebody's faster, I'll do that tonight or tomorrow.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110949 run on x86_64-darwin 1

1 package built:
  • matrix-synapse

@SuperSandro2000 SuperSandro2000 merged commit 90d22ff into NixOS:master Jan 27, 2021
@Ma27
Copy link
Member

Ma27 commented Jan 28, 2021

Since @SuperSandro2000 appears to belong to the group of maintainers who don't care about a stable NixOS, I just took care of the backport: b5339fc :)

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 28, 2021
@SuperSandro2000
Copy link
Member

Is there a simple command where I can just threw the hashes into and the PR gets created automatically? I usually just skip everything related to stable.

@Ma27
Copy link
Member

Ma27 commented Jan 28, 2021

git cherry-pick -x <rev>, rebuild/test, git push upstream/release-YY.MM is for most leaf-packages sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants