Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabula-java: Init at 1.04 #110905

Merged
merged 1 commit into from Feb 10, 2021
Merged

tabula-java: Init at 1.04 #110905

merged 1 commit into from Feb 10, 2021

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Jan 27, 2021

Motivation for this change

Add the CLI tool for tabula, tabula-java.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 27, 2021
View reviewed changes
pkgs/applications/misc/tabula-java/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/tabula-java/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/tabula-java/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/tabula-java/default.nix Outdated Show resolved Hide resolved
@jbaum98 jbaum98 force-pushed the master branch 2 times, most recently from 4122813 to a8e5a5c Compare February 7, 2021 18:32
@jbaum98
Copy link
Contributor Author

jbaum98 commented Feb 9, 2021

I was confused because I'm already in the maintainers file here, but I used the wrong name. I'll fix that.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110905 run on x86_64-darwin 1

1 package built:
  • tabula-java

@SuperSandro2000 SuperSandro2000 merged commit d6bde91 into NixOS:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbaum98 @SuperSandro2000