New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/qemu-guest-agent: fix start service #110927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me from the code changes. I don't have a system to test this, though.
I'd prefer if we could fix this while building qemu itself, not when invoking the We also might be able to test this in a VM test, by waiting for the systemd unit to have succeeded in starting up. The test instrumentation sets |
Don't know how to fix qemu build. |
This path is assembled in This uses the For some reason, this is set to I'm not sure how it works on other distros, but we might just want to ship a downstream patch in nixpkgs, that changes this to another path. (and do some digging upstream about why it's done that way). |
@flokli with add to |
FWIW, I've just got bit by qemu-agent not starting, and this patch helped. As for the approach taken - as far as I know, going with the |
Is this needed to avoid shipping a broken service with 21.05? |
Motivation for this change
Fix start qemu-guest-agent service
cc @Mic92 @blitz @flokli
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)