Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 0ffa153e0a7b
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 1030745555bc
Choose a head ref
  • 10 commits
  • 4 files changed
  • 2 contributors

Commits on Dec 28, 2020

  1. nixos/acme: prevent mass account creation

    Closes #106565
    When generating multiple certificates which all
    share the same server + email, lego will attempt
    to create an account multiple times. By adding an
    account creation target certificates which share
    an account will wait for one service (chosen at
    config build time) to complete first.
    m1cr0man committed Dec 28, 2020
    Copy the full SHA
    85769a8 View commit details
    Browse the repository at this point in the history
  2. nixos/acme: reduce dependency on tmpfiles

    systemd-tmpfiles is no longer required for
    most of the critical paths in the module. The
    only one that remains is the webroot
    acme-challenge directory since there's no
    other good place for this to live and forcing
    users to do the right thing alone will only
    create more issues.
    m1cr0man committed Dec 28, 2020
    Copy the full SHA
    351065f View commit details
    Browse the repository at this point in the history
  3. nixos/acme: change service umask to 0023

    Closes #106603
    Some webservers (lighttpd) require that the
    files they are serving are world readable. We
    do our own chmods in the scripts anyway, and
    lego has sensible permissions on its output
    files, so this change is safe enough.
    m1cr0man committed Dec 28, 2020
    Copy the full SHA
    f670e1d View commit details
    Browse the repository at this point in the history
  4. nixos/acme: update documentation and release notes

    The instructions on recreating the cert were missing --what=state.
    Also added a note on ensuring the group of manual certs is correct.
    m1cr0man committed Dec 28, 2020
    Copy the full SHA
    e5913db View commit details
    Browse the repository at this point in the history
  5. nixos/acme: fix test config

    m1cr0man committed Dec 28, 2020
    Copy the full SHA
    bfe07e2 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. nixos/acme: Remove all systemd-tmpfiles usage

    - Added an ExecPostStart to acme-$cert.service when webroot is defined to create the acme-challenge
    directory and fix required permissions. Lego always tries to create .well-known and acme-challenge,
    thus if any permissions in that tree are wrong it will crash and break cert renewal.
    - acme-fixperms now configured with acme User and Group, however the script still runs as root. This
    ensures the StateDirectories are owned by the acme user.
    - Switched to list syntax for systemd options where multiple values are specified.
    m1cr0man committed Dec 29, 2020
    Copy the full SHA
    92a3a37 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2021

  1. Copy the full SHA
    a01df7d View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    5b4f9c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. nixos/acme: Fix bash issue, enable debug

    I found a logical error in the bash script, but during
    debugging I enabled command echoing and realised it
    would be a good idea to have it enabled all the time for
    ease of bug reporting.
    m1cr0man committed Jan 12, 2021
    Copy the full SHA
    514a0b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Merge pull request #106857 from m1cr0man/master

    nixos/acme: Fixes for account creation and remove tmpfiles usage
    flokli committed Jan 27, 2021
    Copy the full SHA
    1030745 View commit details
    Browse the repository at this point in the history