Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.jupyter-server-proxy: init at 1.5.4 #110907

Closed
wants to merge 2 commits into from

Conversation

costrouc
Copy link
Member

Motivation for this change

Needed for jupyterhub / jupyterlab deployments

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

];

# tests require network
doCheck = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.


meta = with lib; {
description = "Jupyter server extension to supervise and proxy web services";
homepage = https://github.com/jupyterhub/jupyter-server-proxy;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rfc 43

Suggested change
homepage = https://github.com/jupyterhub/jupyter-server-proxy;
homepage = "https://github.com/jupyterhub/jupyter-server-proxy";


meta = with lib; {
description = "Simple async process supervisor";
homepage = https://github.com/yuvipanda/simpervisor;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://github.com/yuvipanda/simpervisor;
homepage = "https://github.com/yuvipanda/simpervisor";

aiohttp
];

checkInputs = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not require checkInputs if no tests are run.

aiohttp
];

checkPhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pytestCheckHook and disabledTests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabledTestFiles, not disabledTests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now actually disabledTestPaths.

@dotlambda dotlambda changed the title pythonPackages.jupyer-server-proxy: init at 1.5.4 pythonPackages.jupyter-server-proxy: init at 1.5.4 Mar 8, 2021
@stale
Copy link

stale bot commented Sep 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants