New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.jupyter-server-proxy: init at 1.5.4 #110907
Conversation
32739bb
to
3241621
Compare
3241621
to
f27edf0
Compare
]; | ||
|
||
# tests require network | ||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If tests are not available, then please use pythonImportsCheck
to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.
|
||
meta = with lib; { | ||
description = "Jupyter server extension to supervise and proxy web services"; | ||
homepage = https://github.com/jupyterhub/jupyter-server-proxy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rfc 43
homepage = https://github.com/jupyterhub/jupyter-server-proxy; | |
homepage = "https://github.com/jupyterhub/jupyter-server-proxy"; |
|
||
meta = with lib; { | ||
description = "Simple async process supervisor"; | ||
homepage = https://github.com/yuvipanda/simpervisor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
homepage = https://github.com/yuvipanda/simpervisor; | |
homepage = "https://github.com/yuvipanda/simpervisor"; |
aiohttp | ||
]; | ||
|
||
checkInputs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not require checkInputs if no tests are run.
aiohttp | ||
]; | ||
|
||
checkPhase = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use pytestCheckHook and disabledTests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabledTestFiles
, not disabledTests
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And now actually disabledTestPaths
.
I marked this as stale due to inactivity. → More info |
Motivation for this change
Needed for jupyterhub / jupyterlab deployments
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)