Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xkeysnail: init at 0.4.0 #110944

Merged
merged 1 commit into from Mar 5, 2021
Merged

xkeysnail: init at 0.4.0 #110944

merged 1 commit into from Mar 5, 2021

Conversation

bb2020
Copy link
Member

@bb2020 bb2020 commented Jan 27, 2021 •
edited

This PR adds xkeysnail python package. The app allows to rebind X11 keyboard input events on per-application basis.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 27, 2021
View reviewed changes
pkgs/tools/X11/xkeysnail/default.nix Outdated
description = "Keyboard remapping tool for X environment";
homepage = "https://github.com/mooz/xkeysnail";
platforms = platforms.linux;
license = licenses.gpl1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpl1only or gpl1Plus?

Copy link
Member Author

@bb2020 bb2020 Jan 31, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says distributed under GPL so I've set it to gpl1Only.

Copy link
Member Author

@bb2020 bb2020 Feb 1, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AUR and PyPI pages also list as GPL.

pkgs/tools/X11/xkeysnail/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@bb2020
Copy link
Member Author

bb2020 commented Jan 27, 2021

I've pushed the changes now.

@bb2020
Copy link
Member Author

bb2020 commented Feb 1, 2021

I've made a few small changes now. I hope you can review it @SuperSandro2000.

@SuperSandro2000
Copy link
Member

I don't know emacs so I can't tell if the config is good.

@SuperSandro2000 SuperSandro2000 merged commit b271820 into NixOS:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bb2020 @SuperSandro2000 @sikmir