Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcode-install: init at 2.6.8 #110923

Merged
merged 1 commit into from Mar 21, 2021
Merged

xcode-install: init at 2.6.8 #110923

merged 1 commit into from Mar 21, 2021

Conversation

q3k
Copy link
Member

@q3k q3k commented Jan 27, 2021

Motivation for this change

Add xcode-install, a Ruby tool to manage globally installed Xcode versions on macOS systems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member

siraben commented Jan 27, 2021

Result of nixpkgs-review pr 110923 run on x86_64-darwin 1

1 package built:
  • xcode-install

siraben
siraben approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@siraben siraben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Builds and runs.

@SuperSandro2000 SuperSandro2000 merged commit 5400fa5 into NixOS:master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siraben siraben siraben approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@q3k @siraben @SuperSandro2000