Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.oci-seccomp-bpf-hook: 1.2.0 -> 1.2.1 #110931

Merged
merged 1 commit into from Jan 27, 2021
Merged

linuxPackages.oci-seccomp-bpf-hook: 1.2.0 -> 1.2.1 #110931

merged 1 commit into from Jan 27, 2021

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jan 27, 2021 •
edited

Motivation for this change

Update to the latest release.

cc @NixOS/podman

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit January 27, 2021 13:06
@SuperSandro2000 SuperSandro2000 changed the title oci-seccomp-bpf-hook: v1.2.0 -> v1.2.1 oci-seccomp-bpf-hook: 1.2.0 -> 1.2.1 Jan 27, 2021
@zowoq
Copy link
Contributor

zowoq commented Jan 27, 2021

Commit message should be linuxPackages.oci-seccomp-bpf-hook: 1.2.0 -> 1.2.1

@saschagrunert
linuxPackages.oci-seccomp-bpf-hook: 1.2.0 -> 1.2.1
057a240 
Signed-off-by: Sascha Grunert <mail@saschagrunert.de>
@saschagrunert
Copy link
Member Author

Commit message should be linuxPackages.oci-seccomp-bpf-hook: 1.2.0 -> 1.2.1

Fixed as suggested 👍

@saschagrunert saschagrunert changed the title oci-seccomp-bpf-hook: 1.2.0 -> 1.2.1 linuxPackages.oci-seccomp-bpf-hook: 1.2.0 -> 1.2.1 Jan 27, 2021
vdemeester
vdemeester approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110931 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • linuxPackages-libre.oci-seccomp-bpf-hook: log was empty
12 packages built:
  • linuxPackages.oci-seccomp-bpf-hook
  • linuxPackages_5_10.oci-seccomp-bpf-hook
  • linuxPackages_hardened.oci-seccomp-bpf-hook
  • linuxPackages_latest-libre.oci-seccomp-bpf-hook
  • linuxPackages_latest_hardened.oci-seccomp-bpf-hook
  • linuxPackages_latest_xen_dom0.oci-seccomp-bpf-hook
  • linuxPackages_latest_xen_dom0_hardened.oci-seccomp-bpf-hook
  • linuxPackages_lqx.oci-seccomp-bpf-hook
  • linuxPackages_testing_bcachefs.oci-seccomp-bpf-hook
  • linuxPackages_xen_dom0.oci-seccomp-bpf-hook
  • linuxPackages_xen_dom0_hardened.oci-seccomp-bpf-hook
  • linuxPackages_zen.oci-seccomp-bpf-hook

@SuperSandro2000 SuperSandro2000 merged commit d785468 into NixOS:master Jan 27, 2021
@saschagrunert saschagrunert deleted the oci-seccomp-bpf-hook branch January 27, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@zowoq zowoq zowoq left review comments

@vdemeester vdemeester vdemeester approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @zowoq @SuperSandro2000 @vdemeester