Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] Revert: cryptopp: 8.2.0 -> 8.4.0 #110935

Merged
merged 2 commits into from Jan 27, 2021
Merged

[20.09] Revert: cryptopp: 8.2.0 -> 8.4.0 #110935

merged 2 commits into from Jan 27, 2021

Conversation

erictapen
Copy link
Member

@erictapen erictapen commented Jan 27, 2021 •
edited

Motivation for this change

Revert #110795.

Reading the release notes of cryptopp, it looks like 8.4.0 actually reintroduces CVE-2019-14318.

Only 8.3.0 does have the fix, but it seems to make things worse.

So I guess it'd make sense to revert this PR? It doesn't have a security benefit and it breaks packages: At least cryfs and it breaks the tests of python2Packages.pycryptopp.

See also my comment on the original PR.

@c0bw3b @dotlambda @LeSuisse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from c0bw3b January 27, 2021 13:34
@erictapen erictapen merged commit 6e20bc6 into NixOS:release-20.09 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeSuisse LeSuisse LeSuisse approved these changes

@dotlambda dotlambda dotlambda approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@c0bw3b c0bw3b Awaiting requested review from c0bw3b

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @LeSuisse @dotlambda