Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-20.03] sudo: 1.8.31 -> 1.9.5p2 #110943

Closed
wants to merge 1 commit into from
Closed

[release-20.03] sudo: 1.8.31 -> 1.9.5p2 #110943

wants to merge 1 commit into from

Conversation

AmineChikhaoui
Copy link
Member

@AmineChikhaoui AmineChikhaoui commented Jan 27, 2021 •
edited

Fixes CVE-2021-3156.

@worldofpeace As one of 20.03 release managers, do you have any preferences w.r.t upgrading to 1.9 or applying patches to 1.8.31 for the CVE ?
I can do either way, I have the patches from Ubuntu for 1.8.31 which seem to apply cleanly.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AmineChikhaoui AmineChikhaoui changed the title sudo: 1.8.31 -> 1.9.5p2 [release-20.03] sudo: 1.8.31 -> 1.9.5p2 Jan 27, 2021
@ofborg ofborg bot requested a review from edolstra January 27, 2021 15:53
@AmineChikhaoui
Copy link
Member Author

Ping @disassembler as well.

@worldofpeace
Copy link
Contributor

20.03 should be EOL now, I don't think we accept security updates?

@worldofpeace
Copy link
Contributor

I have advertised that 20.03 won't be getting security updates because it's EOL #101975. Closing

@AmineChikhaoui AmineChikhaoui deleted the CVE-2021-3156-release-20.03 branch January 27, 2021 17:26
@worldofpeace worldofpeace mentioned this pull request Jan 27, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AmineChikhaoui @worldofpeace