Add notifier configs to grafana provisioning #110942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanbakel
force-pushed
the
grafana-provision-notifiers
branch
3 times, most recently
from
d332842
to
79800f3
Compare
ivanbakel
force-pushed
the
grafana-provision-notifiers
branch
from
79800f3
to
85d440b
Compare
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
roberth
requested review from
offlinehacker,
fpletz,
WilliButz,
globin and
Ma27
|
I didn't really review but I happened to notice option descriptions are missing a trailing period. |
|
Should I add periods to all the other option descriptions in the file as well? |
Similar to dashboards and datasources, notifiers in Grafana can also be provisioned. This adds them to the Grafana service definition.
ivanbakel
force-pushed
the
grafana-provision-notifiers
branch
from
85d440b
to
18df55f
Compare
|
Alright, that's done. |
|
This broke the build for me: The target directory for the symlink is not created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #53874
Motivation for this change
Similar to dashboards and datasources, notifiers in Grafana can also be provisioned. Currently, there is no easy way to configure notifiers through Nix.
See: https://grafana.com/docs/grafana/latest/administration/provisioning/#alert-notification-channels
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)