Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel: 20200922 -> 20210122 #111499

Merged
merged 1 commit into from Feb 19, 2021
Merged

parallel: 20200922 -> 20210122 #111499

merged 1 commit into from Feb 19, 2021

Conversation

bcc32
Copy link
Contributor

@bcc32 bcc32 commented Jan 31, 2021

Motivation for this change

Updating GNU parallel to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested that the patch is no longer necessary, as parallel -X -j2 --tagstring '{#}' echo ::: $(seq 1 100000) correctly splits the argument list into several jobs as needed to satisfy the maximum command line length.

@ofborg ofborg bot requested review from tomberek, vrthra and pSub January 31, 2021 22:09
@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 111499 run on x86_64-linux 1

2 packages built:
  • parallel
  • parallel-full

@tomberek
Copy link
Contributor

Since https://git.savannah.gnu.org/cgit/parallel.git/commit/src/parallel?id=ec2026334368e667a2567f1535b5c2d807ddb224 the patch is no longer needed. Thanks @bcc32!

SuperSandro2000
SuperSandro2000 reviewed Jan 31, 2021
View reviewed changes
pkgs/tools/misc/parallel/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/parallel/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from tomberek February 1, 2021 00:09
@tomberek
Copy link
Contributor

tomberek commented Feb 1, 2021

Squash commits?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111499 run on x86_64-linux 1

1 package marked as broken and skipped:
  • image_optim
8 packages built:
  • adapta-gtk-theme
  • jpeg-archive
  • last
  • parallel
  • parallel-full
  • plata-theme
  • profile-cleaner
  • tebreak

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111499 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • tebreak
1 package failed to build and are new build failure:
2 packages built:
  • last
  • parallel

@bcc32
Copy link
Contributor Author

bcc32 commented Feb 1, 2021 •
edited

@tomberek I was assuming the squash would happen at merge-time. I can also squash eagerly if you would prefer (the extra commit was created using the GitHub accept-suggestion interface).

@tomberek
Copy link
Contributor

tomberek commented Feb 1, 2021

Result of nixpkgs-review pr 111499 run on x86_64-linux 1

1 package marked as broken and skipped:
  • image_optim
8 packages built:
  • adapta-gtk-theme
  • jpeg-archive
  • last
  • parallel
  • parallel-full
  • plata-theme
  • profile-cleaner
  • tebreak

@tomberek
Copy link
Contributor

tomberek commented Feb 1, 2021

@tomberek I was assuming the squash would happen at merge-time. I can also squash eagerly if you would prefer (the extra commit was created using the GitHub accept-suggestion interface).

By default, I tend to squash commits myself to trim down on the "commit noise". I know some projects allow a squash and merge and I think I've seen some discussion about this for Nixpkgs. I don't have merge permissions, so I'm not sure what is currently enabled.

@SuperSandro2000
Copy link
Member

I was assuming the squash would happen at merge-time

It is always nicer to squash them because you can easily forget to squash them.

I'm not sure what is currently enabled.

We have everything enabled.

@bcc32
Copy link
Contributor Author

bcc32 commented Feb 1, 2021

Got it, rebased and squashed.

tomberek
tomberek approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR to add coreutils to path in the wrapper.

pkgs/tools/misc/parallel/default.nix Show resolved Hide resolved
@tomberek
Copy link
Contributor

@ofborg eval
@ofborg build parallel parallel-full

@tomberek tomberek merged commit 16fed7f into NixOS:master Feb 19, 2021
@bcc32
Copy link
Contributor Author

bcc32 commented Feb 19, 2021

Thanks!

@bcc32 bcc32 deleted the parallel-20210122 branch February 19, 2021 16:04
@tomberek
Copy link
Contributor

Thanks!

This was my first ever merge into Nixpkgs! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@tomberek tomberek tomberek approved these changes

@vrthra vrthra Awaiting requested review from vrthra

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcc32 @tomberek @SuperSandro2000 @grahamc