Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/prometheus-exporters/artifactory: init at 1.9.0 #111364

Merged
merged 1 commit into from Mar 11, 2021
Merged

nixos/prometheus-exporters/artifactory: init at 1.9.0 #111364

merged 1 commit into from Mar 11, 2021

Conversation

lbpdt
Copy link
Contributor

@lbpdt lbpdt commented Jan 31, 2021 •
edited

Motivation for this change

Adds a Prometheus exporter to scrape metrics from the API of JFrog Artifactory instances.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lbpdt lbpdt requested a review from WilliButz as a code owner January 31, 2021 00:06
@ofborg ofborg bot requested a review from kalbasit January 31, 2021 00:16
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111364 run on x86_64-darwin 1

1 package failed to build and are new build failure:
  • prometheus-artifactory-exporter: log was empty

@SuperSandro2000
Copy link
Member 

hash mismatch in fixed-output derivation '/nix/store/h850l0r7ylmv6mq8xk5vqd2cx4khf9x5-artifactory_exporter-1.9.0-go-modules':                                                                 wanted: sha256:18piysgiw62qhbv4zlr4lyl872h7xmpz2cxskchvfh73rpcz9izj                                                                                                                         got:    sha256:1594bpfwhbjgayf4aacs7rfjxm4cnqz8iak8kpm1xzsm1cx1il17                                                                                                                       cannot build derivation '/nix/store/sz330gjfvn335r72a3v11p1k262469gk-artifactory_exporter-1.9.0.drv': 1 dependencies couldn't be built                                                      cannot build derivation '/nix/store/i81w4hnbw9kczapnx11hmbx1hngfbplc-env.drv': 1 dependencies couldn't be built

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111364 run on x86_64-darwin 1

1 package built:
  • prometheus-artifactory-exporter

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111364 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • prometheus-artifactory-exporter

@lbpdt lbpdt force-pushed the feature/prometheus-artifactory-exporter branch from d6ce44c to 40fda68 Compare February 9, 2021 09:50
@lbpdt
Copy link
Contributor Author

lbpdt commented Feb 9, 2021 •
edited

Squashed - let me know if you need anything else @SuperSandro2000 .

@lbpdt
Copy link
Contributor Author

lbpdt commented Feb 9, 2021 •
edited

@GrahamcOfBorg test prometheus-exporters.artifactory

@lbpdt lbpdt marked this pull request as draft February 11, 2021 15:50
@lbpdt
nixos/prometheus-exporters/artifactory: init at 1.9.0
458fafa 
Adds a Prometheus exporter to scrape metrics from the API of JFrog
Artifactory instances.
@lbpdt lbpdt force-pushed the feature/prometheus-artifactory-exporter branch from 147c355 to 458fafa Compare February 11, 2021 15:57
@lbpdt lbpdt marked this pull request as ready for review February 11, 2021 15:57
lbpdt
lbpdt commented Feb 16, 2021
View reviewed changes
nixos/modules/services/monitoring/prometheus/exporters/artifactory.nix
cfg = config.services.prometheus.exporters.artifactory;
in
{
port = 9531;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port already defined in the table of default allocations:

https://github.com/prometheus/prometheus/wiki/Default-port-allocations

@lbpdt
Copy link
Contributor Author

lbpdt commented Feb 16, 2021

CC @WilliButz @kalbasit if any of you has time to review this. Thanks!

@lbpdt
Copy link
Contributor Author

lbpdt commented Mar 10, 2021

Gentle ping @SuperSandro2000 @WilliButz @kalbasit . Thanks!

@WilliButz WilliButz merged commit 902a479 into NixOS:master Mar 11, 2021
@lbpdt lbpdt deleted the feature/prometheus-artifactory-exporter branch March 11, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lbpdt @SuperSandro2000 @WilliButz