Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/mobile-nixos
base: 9fbcf888a76e
Choose a base ref
...
head repository: NixOS/mobile-nixos
compare: 9cc2b0ac5f61
Choose a head ref
  • 15 commits
  • 13 files changed
  • 1 contributor

Commits on Jan 28, 2021

  1. boot/init: Fix shellOnFail

     - It was running too late.
     - Wasn't actually using `shellOnFail` config
    samueldr committed Jan 28, 2021
    Copy the full SHA
    5ba41dd View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    76b5e79 View commit details
    Browse the repository at this point in the history
  3. modules/adb: Decouple implementation details

    The service and mount points are more of an implementation detail of the
    GadgetFS handling library and not an implementation detail of the init
    library.
    
    In turn, this means that we are decoupling this from the init, follow-up
    on the next commit...
    samueldr committed Jan 28, 2021
    Copy the full SHA
    4d7bd72 View commit details
    Browse the repository at this point in the history
  4. modules/adb: ADB works just fine on any usb gadget

    (Though it may require fiddling with udev perms)
    samueldr committed Jan 28, 2021
    Copy the full SHA
    6f69402 View commit details
    Browse the repository at this point in the history
  5. boot/init: Add support for FunctionFS on GadgetFS

    FunctionFS on GadgetFS requires this to happen in order:
    
     - (1) preparing the gadget
     - (2) preparing the function
     - (3) mounting the functionfs
     - (4) starting the daemon
     - (5) enabling the device
    
    Doing any of these steps in the wrong order *will* fail. You cannot
    mount functionfs if the function name hasn't been allocated yet. You
    cannot start the daemon without functionfs being mounted. You cannot
    enable the device without the daemon running on the USB endpoints.
    
    This is why the GadgetFS stuff here *has* to know about mounting the
    filesystem and starting the daemon.
    
    In fact, the generic library to be written to handle USB gadget mode
    **will** have to have that knowledge!
    
    The added TODOs are to be done when extracting as a standalone library.
    samueldr committed Jan 28, 2021
    Copy the full SHA
    a96c2b8 View commit details
    Browse the repository at this point in the history
  6. examples/hello: Try to enable ADB

    Also warn if it could not be enabled.
    samueldr committed Jan 28, 2021
    Copy the full SHA
    9d93f32 View commit details
    Browse the repository at this point in the history
  7. examples/target-disk-mode: Try to enable ADB

    Also warn if it could not be enabled.
    samueldr committed Jan 28, 2021
    Copy the full SHA
    c2d948e View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    363f59a View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    594c8eb View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    cb67619 View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    a5f549a View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    3574967 View commit details
    Browse the repository at this point in the history
  13. Copy the full SHA
    d062d81 View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    6baec7a View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2021

  1. Merge pull request #290 from samueldr-wip/feature/gadgetfs-adb

    Enable ADB with GadgetFS devices
    samueldr committed Jan 31, 2021
    Copy the full SHA
    9cc2b0a View commit details
    Browse the repository at this point in the history