Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: haskellPackages.tensorflow: 2020-05-22 -> 2020-11-14 #111399

Closed
wants to merge 2 commits into from
Closed

WIP: haskellPackages.tensorflow: 2020-05-22 -> 2020-11-14 #111399

wants to merge 2 commits into from

Conversation

expipiplus1
Copy link
Contributor

Fixes build, adds support for TF 2.3

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

TerrorJack and others added 2 commits January 29, 2021 21:45
@TerrorJack @peti
Fix ar command path in GHC.
8fae904 
Previously, the "ar command" in the global config of GHC in nixpkgs is
simply "ar" instead of a proper absolute path in the nix store. This
will result in an "ar: command not found" error when using GHC and cabal
in a pure nix shell. This commit adds the patch and applies to all
pre-9.0 versions.

See output of ghc --info for "ar command" value.
@expipiplus1
haskellPackages.tensorflow: 2020-05-22 -> 2020-11-14
b786d0a 
Fixes build, adds support for TF 2.3
cdepillabout
cdepillabout requested changes Feb 1, 2021
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that everything other than tensorflow-proto is marked broken.

Could you mark these as unbroken as well?

@expipiplus1
Copy link
Contributor Author

Ah yeah.

Also although tensorflow works now some other necessary packages such as tensorflow-core-ops are broken pending the haskell package being made compatible with tf 2.4: tensorflow/haskell#271

I'll mark this as WIP until that's resolved.

@expipiplus1 expipiplus1 changed the title haskellPackages.tensorflow: 2020-05-22 -> 2020-11-14 WIP: haskellPackages.tensorflow: 2020-05-22 -> 2020-11-14 Feb 1, 2021
@peti peti force-pushed the haskell-updates branch 3 times, most recently from 36d8f4b to 0b62665 Compare February 5, 2021 22:21
@cdepillabout cdepillabout marked this pull request as draft February 6, 2021 03:47
@cdepillabout
Copy link
Member

cdepillabout commented Feb 6, 2021 •
edited

@expipiplus1 I turned this to a Draft since we're waiting on upstream here, but feel free to flip it back to "Ready for review" when it is ready to be reviewed again.

@mikesperber
Copy link
Contributor

@expipiplus1 I turned this to a Draft since we're waiting on upstream here, but feel free to flip it back to "Ready for review" when it is ready to be reviewed again.

The upstream pull request got merged - could you update this one?

@peti peti force-pushed the haskell-updates branch 2 times, most recently from 915ff7a to f0391f1 Compare February 19, 2021 19:27
@peti peti force-pushed the haskell-updates branch 2 times, most recently from 56fa6fc to f3cb253 Compare February 19, 2021 19:56
@mikesperber
Copy link
Contributor

@expipiplus1 @cdepillabout What's needed to move this one forward? Would it help if I submitted an up-to-date pull request?

@cdepillabout
Copy link
Member

@mikesperber Yes, that would be great!

@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Apr 12, 2021 via email

@mikesperber mikesperber mentioned this pull request Apr 14, 2021
Closed
10 tasks
@mikesperber
Copy link
Contributor

Yeah, might be easier to do that. Thanks!

@cdepillabout @expipiplus1 Done:

#119411

@expipiplus1 expipiplus1 deleted the joe-haskell-tf branch June 9, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout requested changes

@sternenseemann sternenseemann Awaiting requested review from sternenseemann sternenseemann will be requested when the pull request is marked ready for review sternenseemann is a code owner

@maralorn maralorn Awaiting requested review from maralorn maralorn will be requested when the pull request is marked ready for review maralorn is a code owner

@ncfavier ncfavier Awaiting requested review from ncfavier ncfavier will be requested when the pull request is marked ready for review ncfavier is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@expipiplus1 @cdepillabout @mikesperber @TerrorJack