Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv: disable an impure test #111473

Merged
merged 1 commit into from Feb 19, 2021
Merged

libuv: disable an impure test #111473

merged 1 commit into from Feb 19, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 31, 2021

The test relies on connection to 8.8.8.8 port 9999 to hang.

In sandboxed build it is skipped anyway:

ok 270 - tcp_connect_timeout # SKIP Network unreachable.

Motivation for this change

Fix an impurity in libuv build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl changed the title libuv: disable tcp_connect_timeout libuv: disable an impure test Jan 31, 2021
@veprbl veprbl force-pushed the pr/libuv_disable_tcp_connect_timeout branch from 492290a to 09fea12 Compare January 31, 2021 15:10
@ofborg ofborg bot requested a review from cstrahan January 31, 2021 15:16
@veprbl veprbl changed the base branch from master to staging January 31, 2021 16:09
@veprbl
libuv: disable tcp_connect_timeout test
0b214e0 
The test relies on connection to 8.8.8.8 port 9999 to hang.

In sandboxed build it is skipped anyway:

ok 270 - tcp_connect_timeout # SKIP Network unreachable.
@veprbl veprbl force-pushed the pr/libuv_disable_tcp_connect_timeout branch from 09fea12 to 0b214e0 Compare January 31, 2021 16:10
@veprbl veprbl added this to WIP in Staging via automation Jan 31, 2021
@veprbl veprbl moved this from WIP to Needs review in Staging Jan 31, 2021
@veprbl veprbl merged commit 78f3334 into NixOS:staging Feb 19, 2021
Staging automation moved this from Needs review to Done Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: reproducible builds 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@veprbl