Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bottom: 0.5.6 -> 0.5.7 #111386

Merged
merged 1 commit into from Jan 31, 2021
Merged

bottom: 0.5.6 -> 0.5.7 #111386

merged 1 commit into from Jan 31, 2021

Conversation

berbiche
Copy link
Member

Motivation for this change

Update bottom from 0.5.6 to 0.5.7

See https://github.com/ClementTsang/bottom/releases/tag/0.5.7

  • Fixes incorrect colours being used the CPU widget in basic mode
  • Fixes hide_table_gap not working in the battery widget
  • Fixes the sorting arrow disappearing in proc widget under some cases
  • Fixes basic mode failing to report CPUs if there are less than 4 entries to report
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 31, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 31, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marsam marsam merged commit d9a1c01 into NixOS:master Jan 31, 2021
SuperSandro2000
SuperSandro2000 reviewed Jan 31, 2021
View reviewed changes
pkgs/tools/system/bottom/default.nix
@@ -19,7 +19,7 @@ rustPlatform.buildRustPackage rec {

buildInputs = lib.optional stdenv.hostPlatform.isDarwin darwin.apple_sdk.frameworks.IOKit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

darwin should not be used as an input. Instead IOKit should be inputed and inherited in top-level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@berbiche @SuperSandro2000 @marsam