stdenv/darwin: set NIX_COREFOUNDATION_RPATH via hook #111385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
added
6.topic: darwin
cole-h
requested changes
Jan 31, 2021
LnL7
reviewed
Jan 31, 2021
| @@ -503,7 +506,6 @@ in rec { | |||
| targetPlatform = localSystem; | |||
|
|
|||
| preHook = commonPreHook + '' | |||
| export NIX_COREFOUNDATION_RPATH=${pkgs.darwin.CF}/Library/Frameworks | |||
There was a problem hiding this comment.
The main reason this is set directly in the stdenv is to ensure that any usage of frameworks takes priority. The goal here is to link against the pure version as much as possible, but system frameworks also link against the CoreFoundation framework in which case also linking against the pure build causes problems.
There was a problem hiding this comment.
I think that the ordering might be enforced by extraBuildInputs, but just in case there is a simple bash logic in corefoundation-setup-hook.sh to avoid overriding NIX_COREFOUNDATION_RPATH.
This will unset the variable in the cross stdenv where CF is taken out of extraBuildInputs. This is useful for cross compilation to linux where setting RPATH on glibc will break it in runtime. The hook needs to be turned off during the bootstrapping to prevent unwanted references between the stages.
veprbl
force-pushed
the
pr/CF_rpath_hook
branch
from
bc46d34
to
cb5cb29
Compare
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
12 tasks
stale
bot
removed
the
2.status: stale
|
@eliasnaur Yes, please, use the contents of this PR as you see fit. |
12 tasks
|
Thanks, see #230870. |
|
Great. Let's close this then. |
reckenrode
added a commit
to reckenrode/nixpkgs
that referenced
this pull request
May 26, 2023
Closes NixOS#230870. Thanks to @eliasnaur for the test case and for rasining awareness and to @veprbl for the work done on NixOS#111385. This takes a slightly different approach from those two PRs. The hook is set unconditionally. The stdenv bootstrap doesn’t really need CF at all, so setting the hook is harmless. This simplifies things.
reckenrode
added a commit
to reckenrode/nixpkgs
that referenced
this pull request
May 26, 2023
Closes NixOS#230870. Thanks to @eliasnaur for the test case and for rasining awareness and to @veprbl for the work done on NixOS#111385. This takes a slightly different approach from those two PRs. The hook is set unconditionally. The stdenv bootstrap doesn’t really need CF at all, so setting the hook is harmless. This simplifies things.
reckenrode
added a commit
to reckenrode/nixpkgs
that referenced
this pull request
May 29, 2023
Closes NixOS#230870. Thanks to @eliasnaur for the test case and for rasining awareness and to @veprbl for the work done on NixOS#111385. This takes a slightly different approach from those two PRs. The hook is set unconditionally. The stdenv bootstrap doesn’t really need CF at all, so setting the hook is harmless. This simplifies things.
12 tasks
reckenrode
added a commit
to reckenrode/nixpkgs
that referenced
this pull request
May 31, 2023
Closes NixOS#230870. Thanks to @eliasnaur for the test case and for rasining awareness and to @veprbl for the work done on NixOS#111385. This takes a slightly different approach from those two PRs. The hook is set unconditionally. The stdenv bootstrap doesn’t really need CF at all, so setting the hook is harmless. This simplifies things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will unset the variable in the cross stdenv where CF is taken out
of extraBuildInputs. This is useful for cross compilation to linux
where setting RPATH on glibc will break it in runtime.
The hook needs to be turned off during the bootstrapping to prevent
unwanted references between the stages.
Motivation for this change
Fixes darwin -> gnu64 cross compilation
Closes: #103517
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @Gaelan