Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gimx: init at 8.0 #111416

Merged
merged 1 commit into from Feb 1, 2021
Merged

gimx: init at 8.0 #111416

merged 1 commit into from Feb 1, 2021

Conversation

bb2020
Copy link
Member

@bb2020 bb2020 commented Jan 31, 2021

This PR adds Gimx project that allows to emulate various input devices for gaming systems.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/games/gimx/default.nix Outdated Show resolved Hide resolved
pkgs/games/gimx/default.nix Outdated Show resolved Hide resolved
pkgs/games/gimx/default.nix Outdated Show resolved Hide resolved
pkgs/games/gimx/default.nix Outdated Show resolved Hide resolved
pkgs/games/gimx/default.nix Outdated Show resolved Hide resolved
meta = with lib; {
homepage = "https://github.com/matlo/GIMX";
description = "Game Input Multiplexer";
license = licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpl3Only or gpl3Plus?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't figure it out so set it as gpl3Only. It says GPL3 on the Github page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source file headers are saying License: GPLv3.

The project contains code (e. g., oui.c) from BluePy which is licensed under GPLv2+. ArchLinux and Debian are using GPLv3. Looks like that the incompatibility of GPL v2 and v3 is not an issue here.

pkgs/games/gimx/ds4.patch Show resolved Hide resolved
pkgs/games/gimx/env1.patch Outdated Show resolved Hide resolved
pkgs/games/gimx/variant.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111416 run on x86_64-linux 1

2 packages built:
  • gimx
  • gimx-afterglow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants