Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vorta: 0.7.1 -> 0.7.2 #111413

Merged
merged 1 commit into from Feb 1, 2021
Merged

vorta: 0.7.1 -> 0.7.2 #111413

merged 1 commit into from Feb 1, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I noticed a segmentation fault when quitting from the tray icon. But that was already present in the previous version.

@fabaff
Copy link
Member

fabaff commented Jan 31, 2021

Result of nixpkgs-review pr 111413 run on x86_64-linux 1

1 package built:
  • vorta

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...ew/pr-111413]$ ./results/vorta/bin/vorta --version
Vorta 0.7.2

...ew/pr-111413]$ ./results/vorta/bin/vorta 
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
2021-01-31 18:39:49,882 - vorta.i18n - DEBUG - Loading translation succeeded for ['en', 'en-US', 'en-Latn-US'].
2021-01-31 18:39:49,898 - apscheduler.scheduler - INFO - Scheduler started
2021-01-31 18:39:50,153 - root - INFO - Using NetworkManagerMonitor NetworkStatusMonitor implementation.
[...]

I guess that the warnings about the platform can be ignored. Seems to be an issue at my end.

Could you please update the license? It seems to be gpl3Only.

@grahamc grahamc merged commit 86d5d96 into NixOS:master Feb 1, 2021
@dotlambda dotlambda deleted the vorta-0.7.2 branch February 1, 2021 09:58
@dotlambda
Copy link
Member Author

The segmentation fault problem still exists. Maybe some vorta user/maintainer can look into that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants