Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.sql-nvim: Set a default libsqlite3.so #111414

Merged
merged 1 commit into from Feb 1, 2021
Merged

vimPlugins.sql-nvim: Set a default libsqlite3.so #111414

merged 1 commit into from Feb 1, 2021

Conversation

jlesquembre
Copy link
Member

Motivation for this change

The plugin relies on sqlite to work

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ping @teto

@jlesquembre jlesquembre requested a review from teto January 31, 2021 10:10
teto
teto approved these changes Jan 31, 2021
View reviewed changes
Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that fixes it for me. If you use this plugin for telescope/frecency, it would be nice to add sal-nvim as one of its buildinputs in vim-plugins/overrides.nix. Something I can also fix myself later.

@jlesquembre
Copy link
Member Author

that fixes it for me. If you use this plugin for telescope/frecency, it would be nice to add sal-nvim as one of its buildinputs in vim-plugins/overrides.nix. Something I can also fix myself later.

do you mean dependecies instead of buildInputs?

@teto
Copy link
Member

teto commented Feb 1, 2021 •
edited

sry I was like "I should precise it's dependencies and not buildInputs" and ended up writing buildInputs xD

@jlesquembre
vimPlugins.sql-nvim: Set a default libsqlite3.so
9ea9b26 
The plugin relies on sqlite to work. Also, telescosope-frecency-nvim
depends on sql-nvim
@jlesquembre
Copy link
Member Author

@teto no worries, just wanted to be sure, I added the dependendy

@teto
Copy link
Member

teto commented Feb 1, 2021

works for me thnks

@teto teto merged commit 64e4778 into NixOS:master Feb 1, 2021
@jlesquembre jlesquembre deleted the sql-nvim branch February 4, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@teto teto teto approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlesquembre @teto @SuperSandro2000