carla: fixed crash on launch "No module named 'PyQt5.sip'" #111503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently in master, Carla fails to launch with the error:
This failure was traced back to commit 6347fdf from #108041, thanks to
git bisect
(thank you for your existence).After that, it was kind of a shot in the dark, I remembered that Python dependencies needed to be specified under "propagatedBuildInputs" and not "buildInputs". I am not sure why the python wrapping was missing
PyQt5_sip
and other things, but it should be fixed, now.Also fixed
carla-database
since I noticed it wasn't properly wrapped.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)