Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carla: fixed crash on launch "No module named 'PyQt5.sip'" #111503

Merged
merged 2 commits into from Jan 31, 2021

Conversation

minijackson
Copy link
Member

Motivation for this change

Currently in master, Carla fails to launch with the error:

Traceback (most recent call last):
  File "/nix/store/s2k98gvi5p4srqsrspjyszdk9nh2w8r9-carla-2.2.0/share/carla/carla", line 23, in <module>
    from carla_host import *
  File "/nix/store/s2k98gvi5p4srqsrspjyszdk9nh2w8r9-carla-2.2.0/share/carla/carla_host.py", line 40, in <module>
    from PyQt5.QtCore import (
ModuleNotFoundError: No module named 'PyQt5.sip'

This failure was traced back to commit 6347fdf from #108041, thanks to git bisect (thank you for your existence).

After that, it was kind of a shot in the dark, I remembered that Python dependencies needed to be specified under "propagatedBuildInputs" and not "buildInputs". I am not sure why the python wrapping was missing PyQt5_sip and other things, but it should be fixed, now.

Also fixed carla-database since I noticed it wasn't properly wrapped.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants