Fix: [CMake] Restore 'games' as default install bindir #8629
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8599
Motivation / Problem
On Debian-based distributions, the executable should go to
<prefix>/games
, not<prefix>/bin
.Before switching to CMake, our old
configure
used to default to<prefix>/games
.Our CMake script uses
GNUInstallDirs
, which defaults to<prefix>/bin
Description
I restored
games
as default install bin dir, like it was inconfigure
. We already set default data dir toshare/games
anyway.Limitations
Package maintainers will need to set
CMAKE_INSTALL_BINDIR
if default doesn't match their target OS, but they are already used to do similar with the oldconfigure
.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.