Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/types: add description for functionTo #111459

Merged
merged 1 commit into from Jan 31, 2021
Merged

lib/types: add description for functionTo #111459

merged 1 commit into from Jan 31, 2021

Conversation

Scriptkiddi
Copy link
Contributor

@Scriptkiddi Scriptkiddi commented Jan 31, 2021 •
edited

… commit message for your changes. Lines starting

Motivation for this change

While working on #76184 i was wondering why some options show up as having no type even though they are of the type functionTo. @dasJ told me that because the type functionTo (doesn't have a description) they landed on that list. To keep things consistent I added a description.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mohe2015
Copy link
Contributor

mohe2015 commented Jan 31, 2021 •
edited

You messed up the commit message (I was on my phone, could've written it a little bit nicer)

@Scriptkiddi
Copy link
Contributor Author

You messed up the commit message

thanks

@Scriptkiddi Scriptkiddi changed the title lib/types: add description for functionTo and uniq # Please enter the… lib/types: add description for functionTo and uniq Jan 31, 2021
@Scriptkiddi Scriptkiddi changed the title lib/types: add description for functionTo and uniq lib/types: add description for functionTo Jan 31, 2021
@infinisil infinisil merged commit 919b1f5 into NixOS:master Jan 31, 2021
@Scriptkiddi Scriptkiddi deleted the types branch February 1, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Scriptkiddi @mohe2015 @infinisil