Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter: added dev libraries for the emulator #111492

Merged
merged 1 commit into from Feb 2, 2021
Merged

flutter: added dev libraries for the emulator #111492

merged 1 commit into from Feb 2, 2021

Conversation

drsk0
Copy link
Contributor

@drsk0 drsk0 commented Jan 31, 2021

Four additional libraries seem to be needed to start the emulator on my
machine.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
Copy link
Contributor

@RobinKrom Please rebase with master (it is not using the latest changes from #111187).

Also, can you give me some instructions on how to test this? I am having some issues with adb while running the project:

~/Projects/nixpkgs/test_project flutter_addition_emulator_dependencies*
❯ ../result/bin/flutter run
Unable to run "adb", check your Android SDK installation and ANDROID_SDK_ROOT environment variable:
/nix/store/ddxr87zcd1l2hzfginpaclm4ablzx0wk-platform-tools-29.0.6/libexec/android-sdk/platform-tools/adb

I think those adb issues may be related on how the emulator doesn't start, so maybe fixing them in this PR is the way to go.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111492 run on x86_64-linux 1

2 packages built:
  • flutter
  • hover

@SuperSandro2000
Copy link
Member

@ofborg eval

@drsk0
Copy link
Contributor Author

drsk0 commented Feb 1, 2021 •
edited

Hi @thiagokokada, I'll rebase. You can test with flutter emulators --launch Pixel_3a_API_30_x86. You'll have to create the emulated device first, I did that in Android studio.

@drsk0
flutter: added dev libraries for the emulator
e619018 
Four additional libraries seem to be needed to start the emulator on my
machine.
@drsk0 drsk0 force-pushed the flutter_addition_emulator_dependencies branch from b58d033 to e619018 Compare February 1, 2021 10:08
@ericdallo
Copy link
Member

ericdallo commented Feb 1, 2021 •
edited

Oh, that's great we can now launch emulators from flutter emulators :D, thank you for that!

@thiagokokada
Copy link
Contributor

thiagokokada commented Feb 1, 2021 •
edited

Result of nixpkgs-review pr 111492 run on x86_64-linux 1

2 packages built:
  • flutter (flutterPackages.stable)
  • hover

Tested with flutter emulators --launch Pixel_2_API_30 and flutter run.

@SuperSandro2000 SuperSandro2000 merged commit 5c289fb into NixOS:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@ericdallo ericdallo Awaiting requested review from ericdallo

@babariviere babariviere Awaiting requested review from babariviere

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@drsk0 @thiagokokada @SuperSandro2000 @ericdallo @Janik-Haag