Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniflux: 2.0.23 -> 2.0.27 #111465

Merged
merged 1 commit into from Jan 31, 2021
Merged

miniflux: 2.0.23 -> 2.0.27 #111465

merged 1 commit into from Jan 31, 2021

Conversation

lxea
Copy link
Contributor

@lxea lxea commented Jan 31, 2021

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111465 run on x86_64-darwin 1

1 package built:
  • miniflux

benpye
benpye approved these changes Jan 31, 2021
View reviewed changes
Copy link
Contributor

@benpye benpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I wonder if there is a way to get the client tests running within the sandbox environment, presumably they only require loopback network access?

@SuperSandro2000 SuperSandro2000 merged commit 800b760 into NixOS:master Jan 31, 2021
@lxea lxea deleted the miniflux-2.0.27 branch February 1, 2021 09:09
@lxea
Copy link
Contributor Author

lxea commented Feb 1, 2021 •
edited

Looks good to me - I wonder if there is a way to get the client tests running within the sandbox environment, presumably they only require loopback network access?

Unfortunately it seems to require external network connections -- it connects to httpbin https://github.com/miniflux/v2/blob/2cf9bde1af259bd3a2a82471ea5885853e367f53/http/client/client_test.go#L12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpye benpye benpye approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@rvolosatovs rvolosatovs Awaiting requested review from rvolosatovs

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lxea @SuperSandro2000 @benpye @nyanotech @Janik-Haag