darwin.hfs: remove from Libsystem and mark broken #111468
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg eval |
hfs was introduced in e6f7f29 (NixOS#47678), but it seems nobody will needs its pure headers. We drop it from Libsystem.
|
@matthewbauer Do you remember why we needed hfs headers? |
siraben
approved these changes
Feb 5, 2021
|
So I think hfs required at some point for some packages. I would bet Apple is not using them much internally any more. Regardless, it's not too hard to add it as an additional dependency where it is. |
matthewbauer
approved these changes
Feb 5, 2021
veprbl
requested changes
Feb 6, 2021
There was a problem hiding this comment.
This breaks stdenv:
localauth_k5login.c:41:10: fatal error: 'hfs/hfs_mount.h' file not found
#include <hfs/hfs_mount.h>
^~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [Makefile:918: localauth_k5login.so] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/private/tmp/nix-build-libkrb5-1.18.drv-0/krb5-1.18/src/lib/krb5/os'
make[1]: *** [Makefile:1154: all-recurse] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-libkrb5-1.18.drv-0/krb5-1.18/src/lib/krb5'
make: *** [Makefile:1004: all-recurse] Error 1
builder for '/nix/store/qqhkxy6c8n3a67cfqbivmx89p5pgh0hg-libkrb5-1.18.drv' failed with exit code 2
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
hfs was introduced in e6f7f29 (#47678), but it seems nobody will needs its pure headers. We drop it from Libsystem.
For those really need it, they should input hfs themselves.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)