Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.cachetools: 4.1.1 -> 4.2.1 #111483

Merged
merged 3 commits into from Feb 1, 2021
Merged

python3Packages.cachetools: 4.1.1 -> 4.2.1 #111483

merged 3 commits into from Feb 1, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 31, 2021

Motivation for this change

Update to latest upstream release 4.2.1

Change log: https://github.com/tkem/cachetools/blob/master/CHANGELOG.rst#v421-2021-01-24

This PR also enables the test as GitHub is now used to get the source.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

The override in python-packages.nix for cachetools_2 got broken.

@fabaff
Copy link
Member Author

fabaff commented Feb 1, 2021

The override in python-packages.nix for cachetools_2 got broken.

I removed cachetools_2. It doesn't seems to used anywhere here.

~/nixpkgs]$ git grep "cachetools_2"
pkgs/top-level/python-packages.nix:    cachetools_2 = cachetools'.overridePythonAttrs (oldAttrs: rec {
pkgs/top-level/python-packages.nix:  in if isPy3k then cachetools' else cachetools_2;

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111483 run on x86_64-linux 1

1 package built:
  • python3Packages.cachetools

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111483 run on x86_64-darwin 1

1 package built:
  • python3Packages.cachetools

@SuperSandro2000 SuperSandro2000 merged commit e1cc38d into NixOS:master Feb 1, 2021
@fabaff fabaff deleted the bump-cachetools branch February 1, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabaff @SuperSandro2000