lib/generators: fix toPretty throwing on (partially applied) builtins #111469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
An high level example case of the issue occuring can be found below:
The issue, as it turns out is that while builtins are functions,
builtins.functionArgs
throws if is passed a builtin or a partiallyapplied builtin:
I'm pretty sure this qualifies as a nix bug and should be filedEdit: seems like this has been resolved inaccordingly,
nixUnstable
andonly the latest stable version of nix is affected.
We can work around this in lib.generators.toPretty by
using
tryEval
and falling back to {} whichfunctionArgs
should returnfor builtins.
The nix behavior is inconsistent to say the least:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)