Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.postgrest: broken -> unbroken #111480

Closed
wants to merge 271 commits into from
Closed

haskellPackages.postgrest: broken -> unbroken #111480

wants to merge 271 commits into from

Conversation

danielstaleiny
Copy link
Contributor

@danielstaleiny danielstaleiny commented Jan 31, 2021 •
edited

Remove postgrest package from broken list, it builds fine on the latest unstable-small nixos.

Are there other tests I should perform ?

I also tested the package in question to test if it runs, and runs fine as it should.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ X ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [ X ] Fits CONTRIBUTING.md.

cdepillabout
cdepillabout requested changes Jan 31, 2021
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase this change on the haskell-updates branch (as well as changing the base branch here on GitHub)?

We always try to merge these Haskell-related changes into the haskell-updates branch.

@danielstaleiny danielstaleiny changed the base branch from master to haskell-updates February 1, 2021 07:51
aanderse and others added 10 commits February 1, 2021 08:54
@aanderse @danielstaleiny
nixos/nextcloud: add phpExtraExtensions option
9173ea4
@aanderse @danielstaleiny
nixos/nextcloud: remove duplicate php.ini entries
ce128b4
@turion @danielstaleiny
nixos/nextcloud: add documentation for phpExtraExtensions option
5185bc0
@turion @danielstaleiny
nixos/nextcloud: Conditionally enable caching PHP extensions
cc97ac3
@dotlambda @danielstaleiny
libgcrypt_1_5: mark as insecure
877ab8f
@thiagokokada @danielstaleiny
Revert "flutter: 1.22.4 -> 1.22.5"
dc38b15 
This reverts commit 5f72a82.
@thiagokokada @danielstaleiny
flutter: small refactorings in derivation
4c8fb78
@zowoq @danielstaleiny
shfmt: 3.2.1 -> 3.2.2
e078f3e 
https://github.com/mvdan/sh/releases/tag/v3.2.2
@r-ryantm @danielstaleiny
flyway: 7.3.1 -> 7.5.2
0bef23a
@r-burns @danielstaleiny
release-cross: add ppc64le, ppc64le-musl
cecb815 
Our support for ppc64le is pretty good now.
Let's add these so it's easier to spot and rectify breakage.

The toolchains are already built for their bootstrap tools,
so this shouldn't put much build strain on hydra.
Scriptkiddi and others added 14 commits February 1, 2021 08:55
@Scriptkiddi @danielstaleiny
nixos/cinnamon: add sessionPath type
9df9384
@Scriptkiddi @danielstaleiny
nixos/gnome3: add sessionPath type
394bf16
@Scriptkiddi @danielstaleiny
nixos/pantheon: add sessionPath type
d7d72ee
@Scriptkiddi @danielstaleiny
nixos/lightdm-greeters/gtk: add type
0fbd790
@Scriptkiddi @danielstaleiny
nixos/xserver: add serverFlagsSection type
8a767cc
@Scriptkiddi @danielstaleiny
nixos/exwm: add loadScript type
d158399
@Scriptkiddi @danielstaleiny
nixos/xmonad: add haskellPackages type
010bb20
@Scriptkiddi @danielstaleiny
nixos/xtreemfs: add types
f381d6a
@Scriptkiddi @danielstaleiny
nixos/yandex-disk: add types
1f8f368
@Scriptkiddi @danielstaleiny
nixos/xen: add types
4169e86
@risicle @danielstaleiny
gdal_2: 2.4.0 -> 2.4.4
5cb9c57 
remove redundant patches
@r-ryantm @danielstaleiny
portfolio: 0.50.2 -> 0.50.3
bcc32cd
@veehaitch @danielstaleiny
nixos/tests: add kernel-latest-ath-user-regd
171b696 
Test for the option `networking.wireless.athUserRegulatoryDomain` to
make sure the underlying patch still applies for the latest kernel.

Also see #108725.
@danielstaleiny
remove postgrest package from broken-packages ->
82d1e29 
it is unbroken, and builds fine
@danielstaleiny
Copy link
Contributor Author

I messed up the whole pull request when changing base branch, I will make new clean Pull request.

@danielstaleiny danielstaleiny mentioned this pull request Feb 1, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout requested changes

@edolstra edolstra Awaiting requested review from edolstra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@nbp nbp Awaiting requested review from nbp

@peti peti Awaiting requested review from peti peti is a code owner

@RaghavSood RaghavSood Awaiting requested review from RaghavSood RaghavSood is a code owner

@stigtsp stigtsp Awaiting requested review from stigtsp stigtsp is a code owner

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

Assignees
No one assigned
Labels
6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: policy discussion 6.topic: printing 6.topic: python 6.topic: stdenv Standard environment 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet