Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcsh: workaround source moving to old subdirectory after new release #111479

Merged
merged 1 commit into from Jan 31, 2021
Merged

tcsh: workaround source moving to old subdirectory after new release #111479

merged 1 commit into from Jan 31, 2021

Conversation

twhitehead
Copy link
Contributor

Motivation for this change

Upstream moves the source to an old subdirectory when a new version is released. Add this subdirectory to the urls so downloading doesn't break when this occurs (as just finished happening to the NixOS 20.09 release).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@twhitehead twhitehead mentioned this pull request Jan 31, 2021
Merged
10 tasks
@SuperSandro2000
Copy link
Member

I am not sure how important ordering is and if we want to list the first mirror with normal and old directory first.

@twhitehead
Copy link
Contributor Author

Ha. I wondered briefly about that when I did. Done now. 👍

@SuperSandro2000 SuperSandro2000 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 31, 2021
@SuperSandro2000 SuperSandro2000 merged commit 50a03be into NixOS:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@twhitehead @SuperSandro2000