Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.prometheus-flask-exporter: init at 0.18.1 #111474

Merged
merged 1 commit into from Feb 9, 2021
Merged

pythonPackages.prometheus-flask-exporter: init at 0.18.1 #111474

merged 1 commit into from Feb 9, 2021

Conversation

lbpdt
Copy link
Contributor

@lbpdt lbpdt commented Jan 31, 2021

Motivation for this change

This package allows a python Flask application to easily expose Prometheus metrics.

It is not a standalone exporter but is meant to be used as a library, so I didn't add a Prometheus exporter for NixOS under nixos/modules/services/monitoring/prometheus/exporters/.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lbpdt lbpdt force-pushed the feature/prometheus-flask-exporter branch from c3a46b4 to ad426cd Compare January 31, 2021 18:55
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111474 run on x86_64-linux 1

3 packages built:
  • python37Packages.prometheus-flask-exporter
  • python38Packages.prometheus-flask-exporter
  • python39Packages.prometheus-flask-exporter

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.prometheus-flask-exporter:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python38Packages.prometheus-flask-exporter:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python39Packages.prometheus-flask-exporter:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111474 run on x86_64-darwin 1

3 packages built:
  • python37Packages.prometheus-flask-exporter
  • python38Packages.prometheus-flask-exporter
  • python39Packages.prometheus-flask-exporter

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.prometheus-flask-exporter:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python37Packages.prometheus-flask-exporter:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python38Packages.prometheus-flask-exporter:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python39Packages.prometheus-flask-exporter:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@lbpdt
Copy link
Contributor Author

lbpdt commented Feb 8, 2021

Do you need anything else to approve this PR @SuperSandro2000 ?

@SuperSandro2000
Copy link
Member

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

Tell pytest(CheckHook) where to find the tests included in the package
Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@lbpdt lbpdt force-pushed the feature/prometheus-flask-exporter branch from ad426cd to 1795963 Compare February 9, 2021 08:19
@lbpdt
Copy link
Contributor Author

lbpdt commented Feb 9, 2021 •
edited

Good point, should be better now.

@SuperSandro2000 SuperSandro2000 merged commit e3fa2c5 into NixOS:master Feb 9, 2021
@lbpdt lbpdt deleted the feature/prometheus-flask-exporter branch February 9, 2021 09:42
@lbpdt lbpdt restored the feature/prometheus-flask-exporter branch February 9, 2021 09:49
@lbpdt lbpdt deleted the feature/prometheus-flask-exporter branch February 9, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lbpdt @SuperSandro2000