Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rage: skip check if not x86 #111494

Merged
merged 1 commit into from Feb 1, 2021
Merged

rage: skip check if not x86 #111494

merged 1 commit into from Feb 1, 2021

Conversation

rien
Copy link
Contributor

@rien rien commented Jan 31, 2021

Motivation for this change

This package was failing to build on aarch64 because a development dependency in the check phase is x86 only.

Things done

Set doCheck = true only for x86 systems.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rien
rage: skip check if not x86
aa86e0a 
rage has a dev-dependency which uses x86-only assembly and thus fails
when performing the check phase. This sets `doCheck = false` for systems
which are not x86.
@rien
Copy link
Contributor Author

rien commented Jan 31, 2021

Should I fix the stdenv.lib warnings? And if so: how?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 31, 2021 •
edited

Should I fix the stdenv.lib warnings? And if so: how?

Already fixed it

@ofborg eval

@rien rien mentioned this pull request Jan 31, 2021
Merged
@ofborg ofborg bot requested review from ryantm and marsam January 31, 2021 21:56
@grahamc grahamc merged commit b1d651e into NixOS:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm Awaiting requested review from ryantm

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rien @SuperSandro2000 @grahamc @Janik-Haag