Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/resilio: add sharedFolders type #111432

Merged
merged 1 commit into from Feb 4, 2021
Merged

nixos/resilio: add sharedFolders type #111432

merged 1 commit into from Feb 4, 2021

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change

#76184

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cole-h
cole-h approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, thanks!

(FWIW: I checked by running with lib; (types.listOf (types.attrsOf types.anything)).check on the example here inside of nix repl.)

@cole-h cole-h merged commit d7ee2a1 into NixOS:master Feb 4, 2021
@Scriptkiddi Scriptkiddi deleted the resilio branch February 4, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@cwoac cwoac Awaiting requested review from cwoac

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Scriptkiddi @cole-h