Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] autoconf: 2.70 -> 2.71 #111431

Merged
merged 4 commits into from May 14, 2021
Merged

[staging] autoconf: 2.70 -> 2.71 #111431

merged 4 commits into from May 14, 2021

Conversation

andir
Copy link
Member

@andir andir commented Jan 31, 2021

Motivation for this change

This updates autoconf to 2.71. This version appears to be mostly a stable release handling some of the breakage of 2.70 and/or fixing compat with newer clang version (on e.g. the Apple M1 machines).

I kept the addition and the switch of the version separate so that we can just revert the switch in case this causes trouble without closing the door on packages (or platforms) requiring the newer version in the future.

Things done
  • I did run a few NixOS VM tests with with this
  • Built the entire NixOS release set with this (still in process, waiting on my hydra)

@andir andir requested a review from alyssais January 31, 2021 11:08
This is a newer version of autoconf that fixes a bunch of issues that occured
since the last autoconf release and they also fixed one issue with clang that I
ran into while trying out Nix on aarch64-darwin [1].

[1] http://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=commit;h=de36ccf6637974f4faba3747813d38ee46e77d69
@SuperSandro2000
Copy link
Member

I've created #111472 to fix the eval error.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 31, 2021

@ofborg eval

Tests are very flaky and depend on the exact execution environment. It
is weird that it has gone well so far but started causing issues across
many of my builders.

Also started rewording some of the comments in the expression so
hopefully the next person looking at this has an easier time to
understand it.

On systems where swap is available and fully used tests fail like this:

>    def test_swap_memory(self):
>         mem = psutil.swap_memory()
>         self.assertEqual(
>             mem._fields, ('total', 'used', 'free', 'percent', 'sin', 'sout'))
>
>         assert mem.total >= 0, mem
>         assert mem.used >= 0, mem
>         if mem.total > 0:
>             # likely a system with no swap partition
> >           assert mem.free > 0, mem
> E           AssertionError: sswap(total=1048567808, used=1048567808, free=0, percent=100.0, sin=50741248, sout=1316823040)
> E           assert 0 > 0
> E            +  where 0 = sswap(total=1048567808, used=1048567808, free=0, percent=100.0, sin=50741248, sout=1316823040).free

Upstream bug report: giampaolo/psutil#1911

Systems where /proc/mounts doesn't expose any mount points to build the
tests fail like this:

>     def test_disk_partitions(self):
>             self.assertIsInstance(nt.device, str)
>         def check_ntuple(nt):
>             self.assertIsInstance(nt.mountpoint, str)
>             self.assertIsInstance(nt.fstype, str)
>             self.assertIsInstance(nt.opts, str)
>             self.assertIsInstance(nt.maxfile, (int, type(None)))
>             self.assertIsInstance(nt.maxpath, (int, type(None)))
>                 self.assertGreater(nt.maxfile, 0)
>             if nt.maxfile is not None and not GITHUB_ACTIONS:
>             if nt.maxpath is not None:
>                 self.assertGreater(nt.maxpath, 0)
>
>         # all = False
>         ls = psutil.disk_partitions(all=False)
> >       self.assertTrue(ls, msg=ls)
> E       AssertionError: [] is not true : []

Upstream bug report: giampaolo/psutil#1912
@andir
Copy link
Member Author

andir commented Jan 31, 2021

I added one commit that touches pythonPackages.psutil as otherwise the build wouldn't work on any of my systems anymore. See the commit message for details. Would appreciate a review from @jonringer.

@jonringer
Copy link
Contributor

I'll start a review on my server.. might take a while

@andir
Copy link
Member Author

andir commented Feb 1, 2021

I've started a full NixOS release job here https://hydra.h4ck.space/eval/1918#tabs-new (IPv6-only) and you can use my binary cache to ease the load on your machines:

--option substituters "https://cache.nixos.org/ https://cache.h4ck.space/" --option trusted-public-keys "zeta:9zm3cHRlqz3T9HnRsodtQGGqHOLDAiB+8d0kOKnFI0M= cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY="

@jonringer
Copy link
Contributor

I really need to get https://github.com/jonringer/basinix going. Would make this a whole lot easier.

@FRidh FRidh added this to the 21.05 milestone Feb 20, 2021
@FRidh FRidh added this to WIP in Staging via automation Feb 20, 2021
@thefloweringash
Copy link
Member

I'd like to see this progress. Did those reviews complete, and were there any interesting failures? (polite bump)

@vcunat
Copy link
Member

vcunat commented May 11, 2021

@jonringer: you meant the mess shown in GitHub UI, right? I cleaned it by juggling the merge base.

@ofborg ofborg bot requested review from edolstra and jonringer and removed request for jonringer and edolstra May 11, 2021 14:13
@bobrik
Copy link
Contributor

bobrik commented May 12, 2021

Anything else stopping this? I believe this is one of the blockers for #105026.

@vcunat vcunat merged commit 0023f45 into NixOS:staging May 14, 2021
Staging automation moved this from WIP to Done May 14, 2021
@andir andir deleted the autoconf271 branch May 16, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

9 participants