Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovito: init at 3.4.0 #111396

Merged
merged 1 commit into from Feb 1, 2021
Merged

ovito: init at 3.4.0 #111396

merged 1 commit into from Feb 1, 2021

Conversation

twhitehead
Copy link
Contributor

Motivation for this change

Making NixOS even better with one more package... 馃槈

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Jan 31, 2021

Result of nixpkgs-review pr 111396 run on x86_64-linux 1

1 package built:
  • ovito

pkgs/applications/graphics/ovito/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/ovito/default.nix Outdated Show resolved Hide resolved
@twhitehead
Copy link
Contributor Author

Thanks for the reviews all. It all looks good to me. I've squashed it into the init commit and re-pushed.

@dotlambda
Copy link
Member

This seems to be a duplicate of pkgs/development/python-modules/ovito/default.nix. We should remove one of them.

@twhitehead
Copy link
Contributor Author

Ah. That was my bad. I hadn't realized ovito was already packaged. Sorry about that. My best guess is I searched for ovita when I checked search.nixos.org instead of ovito (originally had the name wrong in my head).

I'm thinking maybe though, since it really is a GUI applications first and a python library second, maybe a second pull that

  • combine the two derivations into the pkgs/applications/graphical/ovito location
  • use the standard toPythonModule thing on this to give the python bindings

@dotlambda
Copy link
Member

dotlambda commented Feb 8, 2021

Sounds good! Can you do that, @twhitehead?
cc @siraben @prusnak

@twhitehead
Copy link
Contributor Author

After a lot of messing around trying to figure out how to actually get the python components to build, I finally discovered it is now only available in the licensed version.

This also explains why the existing python version doesn't actually provide any python libraries. Guess they most sensible thing then to do is just entirely drop the python one.

@dotlambda dotlambda mentioned this pull request Feb 13, 2021
10 tasks
@twhitehead twhitehead deleted the ovito branch February 16, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants