New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous XFCE plugin updates #111394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small modification to standardize the directory structure of XFCE expressions.
ofborg
bot
added
8.has: documentation
10.rebuild-darwin: 0
10.rebuild-linux: 11-100
labels
Jan 31, 2021
taku0
approved these changes
Jan 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise LGTM.
AndersonTorres
changed the title
Xfce - my last updates
Miscellaneous XFCE plugin updates
Jan 31, 2021
@@ -42,6 +56,6 @@ stdenv.mkDerivation rec { | |||
description = "CPU graph show for Xfce panel"; | |||
license = licenses.gpl2Plus; | |||
platforms = platforms.linux; | |||
maintainers = [ maintainers.AndersonTorres ]; | |||
maintainers = [ ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not ideal to leave packages without any maintainer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: xfce
The Xfce Desktop Environment
8.has: documentation
10.rebuild-darwin: 0
10.rebuild-linux: 11-100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I am using Wayland now, and I am willing to test Arcan+Durden; I am not using XFCE anymore.
Because of it, I will no longer maintain these packages.
I updated the plugins according to the info available on Repology, and reordered the files in order to produce a more orthogonal organization. Instead of various
xfce-<name>-plugin.nix
we now have variousxfce-<name>-plugin/default.nix
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)