Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous XFCE plugin updates #111394

Merged
merged 29 commits into from Jan 31, 2021
Merged

Miscellaneous XFCE plugin updates #111394

merged 29 commits into from Jan 31, 2021

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jan 31, 2021

Motivation for this change

I am using Wayland now, and I am willing to test Arcan+Durden; I am not using XFCE anymore.
Because of it, I will no longer maintain these packages.

I updated the plugins according to the info available on Repology, and reordered the files in order to produce a more orthogonal organization. Instead of various xfce-<name>-plugin.nix we now have various xfce-<name>-plugin/default.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: xfce The Xfce Desktop Environment label Jan 31, 2021
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM.

@AndersonTorres AndersonTorres merged commit 9b2b1cd into NixOS:master Jan 31, 2021
@AndersonTorres AndersonTorres changed the title Xfce - my last updates Miscellaneous XFCE plugin updates Jan 31, 2021
@@ -42,6 +56,6 @@ stdenv.mkDerivation rec {
description = "CPU graph show for Xfce panel";
license = licenses.gpl2Plus;
platforms = platforms.linux;
maintainers = [ maintainers.AndersonTorres ];
maintainers = [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not ideal to leave packages without any maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants