Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/qemu-vm: add virtualisation.msize option #111462

Merged
merged 1 commit into from Feb 26, 2021
Merged

nixos/qemu-vm: add virtualisation.msize option #111462

merged 1 commit into from Feb 26, 2021

Conversation

jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Jan 31, 2021 •
edited

Motivation for this change

Allows for setting the msize of the 9p mounts (which must be set at boot as msize cannot be set by remounting).

Setting a size of 8K (the default) or less makes qemu emit a warning.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace merged commit 1546bea into NixOS:master Feb 26, 2021
@jakobrs jakobrs deleted the msize branch February 26, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakobrs @symphorien @worldofpeace