Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx module: fix typo in proxyWebsockets description #111485

Merged
merged 1 commit into from Jan 31, 2021
Merged

nginx module: fix typo in proxyWebsockets description #111485

merged 1 commit into from Jan 31, 2021

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Jan 31, 2021

Motivation for this change

This typo has been there since 2017 without anyone noticing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Luflosi Luflosi added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 31, 2021
@Luflosi
Copy link
Contributor Author

Luflosi commented Jan 31, 2021

This typo is also in the stable version, so it should be fixed there as well, right?

@SuperSandro2000
Copy link
Member

This typo is also in the stable version, so it should be fixed there as well, right?

If we you want to backport it you can do it.

@Luflosi
Copy link
Contributor Author

Luflosi commented Jan 31, 2021

I'll wait til this PR is merged since the manual says that the cherry-picked commit should be in the master branch.

@SuperSandro2000 SuperSandro2000 merged commit 66c11c1 into NixOS:master Jan 31, 2021
@Luflosi Luflosi mentioned this pull request Jan 31, 2021
Merged
10 tasks
@Luflosi Luflosi deleted the fix-typo branch January 31, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luflosi @SuperSandro2000