Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

molden: fix outdated URLs #111484

Merged
merged 1 commit into from Jan 31, 2021
Merged

molden: fix outdated URLs #111484

merged 1 commit into from Jan 31, 2021

Conversation

markuskowa
Copy link
Member

Motivation for this change

Fix outdated URLs and unbreak build. Needs back port to 20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa markuskowa added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 31, 2021
@markuskowa markuskowa merged commit 93519c7 into NixOS:master Jan 31, 2021
@markuskowa markuskowa deleted the fix-molden branch January 31, 2021 18:06
@markuskowa
Copy link
Member Author

back ported to 20.09 in 82dfa1a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@markuskowa