nixos/xmonad: add haskellPackages type #111451
Conversation
| @@ -43,6 +43,7 @@ in { | |||
| haskellPackages = mkOption { | |||
| default = pkgs.haskellPackages; | |||
| defaultText = "pkgs.haskellPackages"; | |||
| type = types.package; | |||
There was a problem hiding this comment.
This does not look correct, it is supposed to be scope of haskell packages, not a single package:
nix-repl> lib.types.package.check pkgs.haskellPackages
false
There was a problem hiding this comment.
I think @jtojnar is correct here. This breaks the build for my configuration on master (which works fine and does not even change this option from the default).
There was a problem hiding this comment.
Would be cool to have a type for package sets of this kind! But this type is indeed not correct and breaks eval for ppl, please revert it.
There was a problem hiding this comment.
sorry about that, this should fix it:
https://github.com/NixOS/nixpkgs/pull/111534/files
There was a problem hiding this comment.
I'm also hitting this issue. This should actually be a function which takes haskellPackages set and returns list of packages.
There was a problem hiding this comment.
@turboMaCk doesn't seem possible, because the module needs it for ghcWithPackages for example. You might be thinking of the extraPackages option instead.
There was a problem hiding this comment.
@roberth yes sorry I missed what line this is. extraPackages is the function I've meant. That one internally uses this attribute.
|
#111581 reverted |
Motivation for this change
#76184
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)