Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6266: Ugly lists in network lobby windows on double/quad interface sizes with custom fonts #8765

Merged
merged 1 commit into from Feb 28, 2021
Merged

Fix #6266: Ugly lists in network lobby windows on double/quad interface sizes with custom fonts #8765

merged 1 commit into from Feb 28, 2021

Conversation

ldpl
Copy link
Contributor

@ldpl ldpl commented Feb 28, 2021 •
edited

Resurrecting patch from #6266 with some minor modifications.

Motivation / Problem

image

Description

image

Server Lobby:

  • List width
  • Lines height
  • Icons and text vertical centering
  • Row highlight height (-1 px to show bottom bevel)

Network servers window:

  • Language icons vertical centering

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain
Copy link
Member

Please don't skip templates. This is lacking several key elements to any PR:

What is the motivation?
What is your solution?
What are we looking at.

There are templates for a reason; redirecting to another PR makes us do the work, which is not fair.

LordAro
LordAro approved these changes Feb 28, 2021
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@LordAro LordAro merged commit 73fd634 into OpenTTD:master Feb 28, 2021
@ldpl ldpl deleted the scaled-network-gui branch September 19, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldpl @TrueBrain @LordAro